Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update chain IDs #2104

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore: update chain IDs #2104

wants to merge 8 commits into from

Conversation

cgilbe27
Copy link
Contributor

@cgilbe27 cgilbe27 commented Oct 31, 2024 •
edited by coderabbitai bot
Loading

Relates to https://github.com/NibiruChain/web-app/issues/1169

Summary by CodeRabbit

  • Chores

    • Updated chain IDs for mainnet, testnet, devnet, and localnet environments
    • Reduced chain ID values by 300 across all network configurations

  • Documentation

    • Updated CHANGELOG.md to reflect the chain ID modifications

@cgilbe27 cgilbe27 requested a review from a team as a code owner October 31, 2024 18:19
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2024 •
edited
Loading

Walkthrough

The pull request introduces updates to the Ethereum chain IDs in the Nibiru project. The changes involve systematically reducing chain ID values by 300 across mainnet, testnet, devnet, and localnet configurations. This modification is documented in the CHANGELOG.md file with a reference to pull request #2104, indicating a chore-level update to chain ID management. The changes are primarily focused on the appconst.go file, which maintains the chain ID constants and mappings.

Changes

File Change Summary
CHANGELOG.md Added chore entry for chain ID update (PR #2104)
app/appconst/appconst.go Updated Ethereum chain ID constants and mappings:
- Mainnet: 7200 → 6900
- Testnet: 7210-7212 → 6910-6912
- Devnet: 7220-7222 → 6920-6922
- Localnet: 7230-7233 → 6930-6933

Poem

🐰 Chain IDs dancing, numbers rearrange
Hopping down from seven-two-hundred's range
Nibiru's networks, now subtly refined
With chain IDs neatly redesigned
A rabbit's leap of numeric delight! 🔢

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 666a58d and 3b41f92.

📒 Files selected for processing (2)
  • CHANGELOG.md (2 hunks)
  • app/appconst/appconst.go (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • CHANGELOG.md
🔇 Additional comments (9)
app/appconst/appconst.go (9)

56-56: All good for mainnet ID adjustment.

The assignment ETH_CHAIN_ID_MAINNET int64 = 6900 is consistent with the objective of reducing the chain ID by 300.

58-60: Testnet constants updated as requested.

All ETH_CHAIN_ID_TESTNET_* constants have been reduced by 300, aligning with the PR objective.

62-64: Devnet constants updated as requested.

All ETH_CHAIN_ID_DEVNET_* constants have been reduced by 300, aligning with the PR objective.

66-69: Localnet constants updated correctly.

These localnet chain IDs were also lowered by 300, staying in sync with the global chain ID reduction.

71-71: Confirm default chain ID alignment.

ETH_CHAIN_ID_DEFAULT now matches ETH_CHAIN_ID_LOCALNET_0. Verify that this is the intended fallback behavior for unmapped contexts.

Would you like to confirm any potential edge cases or usage patterns to ensure that the default localnet ID is always desired?

75-75: Cataclysm mainnet mapping updated.

The newly assigned 6900 chain ID is consistent with the updated constant.

77-79: Testnet mappings updated accordingly.

All entries in knownEthChainIDMap for testnet now match the new constants (reduced by 300).

81-83: Devnet mappings updated accordingly.

All entries in knownEthChainIDMap for devnet mirror the updated devnet constants.

85-88: Localnet mappings in sync with updated constants.

Each localnet variant is correctly replaced with IDs reduced by 300 in the map.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cgilbe27 cgilbe27 marked this pull request as draft October 31, 2024 18:20
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.09%. Comparing base (666a58d) to head (3b41f92).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2104   +/-   ##
=======================================
  Coverage   65.09%   65.09%           
=======================================
  Files         274      274           
  Lines       21731    21731           
=======================================
  Hits        14145    14145           
  Misses       6613     6613           
  Partials      973      973
Files with missing lines Coverage Δ
app/appconst/appconst.go 60.86% <ø> (ø)

@cgilbe27 cgilbe27 marked this pull request as ready for review December 30, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cgilbe27